Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pino and rxjs as peer depencies #1004 #2103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ch3ric
Copy link

@ch3ric ch3ric commented Oct 30, 2024

@ch3ric
Copy link
Author

ch3ric commented Dec 9, 2024

@iamolegga hi! any chance you get some time to check and validate this PR? :)
If it can help to remember the context and if I understood correctly, you've already approved this fix in a previous comment in the related issue there: #1004 (comment)

@iamolegga
Copy link
Owner

Hi, thanks for reminding me. I am currently too busy at work, but I am planning to get back to this (and other PRs) during the holidays, as it takes some time to carefully review all the version ranges to not to break things for a huge amount of dependants. There are other related PRs that could be merged too.

Thanks for understanding 🙏

@iamolegga
Copy link
Owner

@ch3ric hi! Could you rebase this PR on top of the fresh master, sort lines alphabetically, and squash commits?

@ch3ric
Copy link
Author

ch3ric commented Feb 4, 2025

@ch3ric hi! Could you rebase this PR on top of the fresh master, sort lines alphabetically, and squash commits?

Hello @iamolegga
Done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants